On Thu, 2020-12-17 at 18:03 -0600, Benjamin Marzinski wrote:
> On Thu, Dec 17, 2020 at 12:00:13PM +0100, mwilck@xxxxxxxx wrote:
> >
> > -void free_logarea (void)
> > +static void free_logarea (void)
> > {
> > FREE(la->start);
> > FREE(la->buff);
>
> I realize that the log area can only be freed by log_close(), which
> is
> called when mulitpathd exits, but it would be nice to have la set to
> NULL it's freed, just to make it obvious that that there can't be
> double-frees there.
There's FREE(la) right after this, and FREE(x) sets the pointer to
NULL. So it should be fine, or am I confused?
> However, the code is clearly correct, so
>
> Reviewed-by: Benjamin Marzinski <bmarzins@xxxxxxxxxx>
Thanks,
Martin
--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/dm-devel
