Re: [PATCH 29/44] block: remove the nr_sects field in struct hd_struct

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu 26-11-20 18:52:08, Christoph Hellwig wrote:
> On Thu, Nov 26, 2020 at 05:50:36PM +0100, Jan Kara wrote:
> > > +	if (size == capacity ||
> > > +	    (disk->flags & (GENHD_FL_UP | GENHD_FL_HIDDEN)) != GENHD_FL_UP)
> > > +		return false;
> > > +	pr_info("%s: detected capacity change from %lld to %lld\n",
> > > +		disk->disk_name, size, capacity);
> > > +	kobject_uevent_env(&disk_to_dev(disk)->kobj, KOBJ_CHANGE, envp);
> > 
> > I think we don't want to generate resize event for changes from / to 0...
> 
> Didn't you ask for that in the last round?

I've asked for the message - which you've added :). But the udev event was
correct in the previous version IMHO...

								Honza
-- 
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR

--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/dm-devel




[Index of Archives]     [DM Crypt]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Packaging]     [Fedora SELinux]     [Yosemite Discussion]     [KDE Users]     [Fedora Docs]

  Powered by Linux