On Wed 18-11-20 09:47:41, Christoph Hellwig wrote: > disk_get_part needs to be paired with a disk_put_part. > > Fixes: ef45fe470e1 ("blk-cgroup: show global disk stats in root cgroup io.stat") > Signed-off-by: Christoph Hellwig <hch@xxxxxx> Looks good to me. You can add: Reviewed-by: Jan Kara <jack@xxxxxxx> Honza > --- > block/blk-cgroup.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c > index c68bdf58c9a6e1..54fbe1e80cc41a 100644 > --- a/block/blk-cgroup.c > +++ b/block/blk-cgroup.c > @@ -849,6 +849,7 @@ static void blkcg_fill_root_iostats(void) > blkg_iostat_set(&blkg->iostat.cur, &tmp); > u64_stats_update_end(&blkg->iostat.sync); > } > + disk_put_part(part); > } > } > > -- > 2.29.2 > -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel