On 2020/11/2 5:23, Martin Wilck wrote: > Previously, this code, which flushes maps that aren't valid any more, > would only be called from multipathd() -> reconfigure(), because in all > other cases newmp was NULL. > > AFAICS, you will now call dm_flush_map() even if called with > newmp==NULL (this means, from cli_add_map(), or from multipath, even if > called with CMD_DRY_RUN). I don't think that's what we want. Hi Thanks for your review. I will change my patch to make sure dm_flush_map() is called only when mpvec (newmp in old code) is not NULL. Thanks for your advice again. Regards, Lixiaokeng -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel