Re: [PATCH v2 13/21] libmultipath: provide defaults for {get, put}_multipath_config

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Sep 26, 2020 at 11:43:46AM +0200, Martin Wilck wrote:
> On Fri, 2020-09-25 at 16:57 -0500, Benjamin Marzinski wrote:
> > On Fri, Sep 25, 2020 at 10:00:10PM +0200, Martin Wilck wrote:
> > > 
> > > I suggest to track the verbosity independently in a different
> > > variable,
> > > and just set it from init_config() if it was actually set in the
> > > config file. Most of the time, we set it from the command line.
> > > This would have the additional benefit not to have to call
> > > get_multipath_config() in dlog().
> > 
> > Sure. That sounds like a much simpler solution than what I was
> > proposing.
> 
> I will do that in a separate patch. It will actually be a short
> series with logging fixes. Would you ack this patch then?
> In general it makes sense for get_multipath_config() to return NULL if
> the struct config is not initialized.
> 

Sure.
Reviewed-by: Benjamin Marzinski <bmarzins@xxxxxxxxxx>


> Thanks,
> Martin
> 

--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/dm-devel




[Index of Archives]     [DM Crypt]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Packaging]     [Fedora SELinux]     [Yosemite Discussion]     [KDE Users]     [Fedora Docs]

  Powered by Linux