You've clearly done a nice job with these changes. Looks clean. BUT, I'm struggling to just accept that dm-crypt needs to go to these extra lengths purely because of one bad apple usecase. These alignment constraints aren't new. Are there other portions of Linux's crypto subsystem that needed comparable fixes in order to work with Microsfot OS initiated IO through a guest? You forecast that these same kinds of changes are needed for AEAD and dm-integrity... that's alarming. Are we _certain_ there is no other way forward? (Sorry I don't have suggestions.. I'm in "fact finding mode" ;) Thanks, Mike On Wed, Sep 23 2020 at 1:01pm -0400, Sudhakar Panneerselvam <sudhakar.panneerselvam@xxxxxxxxxx> wrote: > Could someone review this patch set, please? > > Thanks > Sudhakar > > > -----Original Message----- > > From: Sudhakar Panneerselvam > > Sent: Wednesday, September 16, 2020 12:40 PM > > To: agk@xxxxxxxxxx; snitzer@xxxxxxxxxx; dm-devel@xxxxxxxxxx > > Cc: Shirley Ma <shirley.ma@xxxxxxxxxx>; ssudhakarp@xxxxxxxxx; Martin > > Petersen <martin.petersen@xxxxxxxxxx> > > Subject: [RFC PATCH 0/2] dm crypt: Allow unaligned buffer lengths > > for skcipher devices > > > > Hi, > > > > This changeset allows processing of unaligned bio requests in dm crypt > > for the I/Os generated from a windows guest OS in a QEMU environment. If > > this changeset is accepted, then I will be submitting another changeset that > > addresses the similar issue in AEAD disks and dm-integrity module. > > > > Thanks > > Sudhakar > > > > Sudhakar Panneerselvam (2): > > dm crypt: Allow unaligned bio buffer lengths for skcipher devices > > dm crypt: Handle unaligned bio buffer lengths for lmk and tcw > > > > drivers/md/dm-crypt.c | 154 +++++++++++++++++++++++++++++++++++---- > > ----------- > > 1 file changed, 108 insertions(+), 46 deletions(-) > > > > -- > > 1.8.3.1 > > > > -- > > dm-devel mailing list > > dm-devel@xxxxxxxxxx > > https://www.redhat.com/mailman/listinfo/dm-devel > > > -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
