On Wed, Sep 16, 2020 at 05:37:18PM +0200, mwilck@xxxxxxxx wrote:
> From: Martin Wilck <mwilck@xxxxxxxx>
>
> We can use libmultipath's internal symbols now.
>
> Signed-off-by: Martin Wilck <mwilck@xxxxxxxx>
> ---
> mpathpersist/main.c | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/mpathpersist/main.c b/mpathpersist/main.c
> index 0f0db4b..729857f 100644
> --- a/mpathpersist/main.c
> +++ b/mpathpersist/main.c
I'm pretty sure that without this patch, mpathpersist is not directly
calling functions from libmultipath, and if so, it should stay that way.
I don't see any problem with adding the libmultipath_init() and
libmultipath_exit() calls to libmpathpersist_init() and
libmpathpersist_exit().
-Ben
> @@ -42,13 +42,10 @@ void * mpath_alloc_prin_response(int prin_sa);
> void mpath_print_transport_id(struct prin_fulldescr *fdesc);
> int construct_transportid(const char * inp, struct transportid transid[], int num_transportids);
>
> -int logsink;
> -
> void rcu_register_thread_memb(void) {}
>
> void rcu_unregister_thread_memb(void) {}
>
> -struct udev *udev;
>
> static int verbose, loglevel, noisy;
>
> @@ -608,16 +605,17 @@ int main(int argc, char *argv[])
> exit (1);
> }
>
> - udev = udev_new();
> + if (libmultipath_init())
> + exit(1);
> if (libmpathpersist_init()) {
> - udev_unref(udev);
> + libmultipath_exit();
> exit(1);
> }
>
> ret = handle_args(argc, argv, 0);
>
> libmpathpersist_exit();
> - udev_unref(udev);
> + libmultipath_exit();
>
> return (ret >= 0) ? ret : MPATH_PR_OTHER;
> }
> --
> 2.28.0
--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/dm-devel
