On Fri, 2020-09-04 at 15:00 -0500, Benjamin Marzinski wrote: > On Thu, Sep 03, 2020 at 10:08:53PM +0200, Martin Wilck wrote: > > Hello Lixiaokeng, > > > > On Wed, 2020-09-02 at 14:40 +0800, lixiaokeng wrote: > > > Hi: > > > Now, we check multipath-tools codes with codedex tool. Here > > > are some some cleanups and fixes. > > > > Thank you. However I'm going to nack all patches that add error > > messages after unsuccesful memory allocations. Such messages are > > unhelpful most of the time, and increase the code size without a > > true > > benefit. I've actually considered to get rid of all these, and > > replace > > them by a log_oom() macro. > > O.k. This answers my question from patch 0005. I'm fine with this. Great, thanks. > As a side note: man, those are some ugly preprocessor hoops you need > to > jump through to stringify __LINE__. Yeah, it took me some attempts to get it right. It's actually documented: https://gcc.gnu.org/onlinedocs/gcc-4.8.5/cpp/Stringification.html Thanks, Martin -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
