Hello Martin, Thanks for your reviews. I will remove the error messages and send them again. Regards Lixiaokeng On 2020/9/4 4:08, Martin Wilck wrote: > Hello Lixiaokeng, > > On Wed, 2020-09-02 at 14:40 +0800, lixiaokeng wrote: >> Hi: >> Now, we check multipath-tools codes with codedex tool. Here >> are some some cleanups and fixes. > > Thank you. However I'm going to nack all patches that add error > messages after unsuccesful memory allocations. Such messages are > unhelpful most of the time, and increase the code size without a true > benefit. I've actually considered to get rid of all these, and replace > them by a log_oom() macro. > > See an untested prototype attached, to better understand what I mean. > > Regards > Martin > > -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
