On Mon, 2020-08-31 at 19:37 +0800, Zhiqiang Liu wrote: > sd_notify_status() is very similar with daemon_status(), except > DAEMON_IDLE and DAEMON_RUNNING state. As suggested by Martin, > we can create the sd notification string in a dynamic buffer, > and treat DAEMON_IDLE and DAEMON_RUNNING cases first. Then, > we can use daemon_status_msg[state] for other cases. > > V3->V4: > - put "STATUS=" in format string to avoid "prefix" var as suggested > by > Martin. > > V2->V3: > - set MSG_SIZE to 32 and use safe_sprintf as suggested by Martin. > > Signed-off-by: Zhiqiang Liu <liuzhiqiang26@xxxxxxxxxx> > Signed-off-by: lixiaokeng <lixiaokeng@xxxxxxxxxx> > --- > multipathd/main.c | 33 +++++++++++---------------------- > 1 file changed, 11 insertions(+), 22 deletions(-) > Thank you. Reviewed-by: Martin Wilck <mwilck@xxxxxxxx> -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
