In vector_foreach_slot_after macro, i is the input var, which may have a illegal value (i < 0). So we should add lower boundary check in vector_foreach_slot_after macro. V1->V2: - check whether i is illegal before loop (As suggested by Martin) Signed-off-by: Zhiqiang Liu <liuzhiqiang26@xxxxxxxxxx> Signed-off-by: lixiaokeng <lixiaokeng@xxxxxxxxxx> --- libmultipath/vector.h | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/libmultipath/vector.h b/libmultipath/vector.h index 2862dc28..ab80d06e 100644 --- a/libmultipath/vector.h +++ b/libmultipath/vector.h @@ -38,11 +38,12 @@ typedef struct _vector *vector; #define VECTOR_LAST_SLOT(V) (((V) && VECTOR_SIZE(V) > 0) ? (V)->slot[(VECTOR_SIZE(V) - 1)] : NULL) #define vector_foreach_slot(v,p,i) \ - for (i = 0; (v) && (int)i < VECTOR_SIZE(v) && ((p) = (v)->slot[i]); i++) + for ((i) = 0; (v) && (int)(i) < VECTOR_SIZE(v) && ((p) = (v)->slot[i]); (i)++) #define vector_foreach_slot_after(v,p,i) \ - for (; (v) && (int)i < VECTOR_SIZE(v) && ((p) = (v)->slot[i]); i++) + if ((v) && (int)(i) >= 0) \ + for (; (int)(i) < VECTOR_SIZE(v) && ((p) = (v)->slot[i]); (i)++) #define vector_foreach_slot_backwards(v,p,i) \ - for (i = VECTOR_SIZE(v) - 1; (int)i >= 0 && ((p) = (v)->slot[i]); i--) + for ((i) = VECTOR_SIZE(v) - 1; (int)(i) >= 0 && ((p) = (v)->slot[i]); (i)--) #define identity(x) (x) /* -- 2.24.0.windows.2 -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
