On 2020/8/10 18:17, Martin Wilck wrote: > On Mon, 2020-08-10 at 09:14 +0800, Zhiqiang Liu wrote: >> In checker_state_name func, we donot check whether input i >> is valid. It may cause array access violation problem. >> >> Signed-off-by: Zhiqiang Liu <liuzhiqiang26@xxxxxxxxxx> >> --- >> libmultipath/checkers.c | 26 +++++++++++++++----------- >> libmultipath/checkers.h | 3 ++- >> 2 files changed, 17 insertions(+), 12 deletions(-) >> > > Reviewed-by: Martin Wilck <mwilck@xxxxxxxx> > > Thanks for the patch. > > Btw, are you currently reviewing multipath-tools with coverity or some > similar tool? > > Martin Thanks for your reply. Actually, I just read and learned multipath-tools code without using any tools. In the future, we may try to use some scanning tools for deep analysis. Thanks for your review, again. -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
