From: Martin Wilck <mwilck@xxxxxxxx>
We would fail in store_path() at the latest if pathvec was NULL.
And all callers set pathvec anyway.
Signed-off-by: Martin Wilck <mwilck@xxxxxxxx>
---
libmultipath/dmparser.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/libmultipath/dmparser.c b/libmultipath/dmparser.c
index 7fcd76e..e6f2cbe 100644
--- a/libmultipath/dmparser.c
+++ b/libmultipath/dmparser.c
@@ -6,6 +6,7 @@
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
+#include <assert.h>
#include "checkers.h"
#include "vector.h"
@@ -137,6 +138,7 @@ int disassemble_map(vector pathvec, char *params, struct multipath *mpp,
struct path * pp;
struct pathgroup * pgp;
+ assert(pathvec != NULL);
p = params;
condlog(4, "%s: disassemble map [%s]", mpp->alias, params);
@@ -295,8 +297,7 @@ int disassemble_map(vector pathvec, char *params, struct multipath *mpp,
devname[0] = '\0';
}
- if (pathvec)
- pp = find_path_by_devt(pathvec, word);
+ pp = find_path_by_devt(pathvec, word);
if (!pp) {
pp = alloc_path();
--
2.26.2
--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/dm-devel
