From: Martin Wilck <mwilck@xxxxxxxx> This is to be consistent with store_path_with_pathinfo(). It's not strictly necessary; we _could_ proceed in both functions even in the unlikely case that the device name overflows, because we use pp->dev mainly for log messages. However, a device node name that causes an overflow for FILE_NAME_SIZE = 256 should be considered pathologic anyway. Signed-off-by: Martin Wilck <mwilck@xxxxxxxx> --- libmultipath/discovery.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libmultipath/discovery.c b/libmultipath/discovery.c index 10b5a28..81a3fad 100644 --- a/libmultipath/discovery.c +++ b/libmultipath/discovery.c @@ -64,6 +64,7 @@ alloc_path_with_pathinfo (struct config *conf, struct udev_device *udevice, if (safe_sprintf(pp->dev, "%s", devname)) { condlog(0, "pp->dev too small"); + err = 1; } else { pp->udev = udev_device_ref(udevice); err = pathinfo(pp, conf, flag | DI_BLACKLIST); -- 2.26.2 -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel