Re: [PATCH 4/4] libmultipath: fix checker detection for nvme devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2020-07-01 at 17:39 -0500, Benjamin Marzinski wrote:
> In order to fix hwhandler autodetection, commit 8794a776 made
> detect_alua() differentiate between failures to detect whether alua
> was
> supported, and successfully detecting that it was not supported.
> However, this causes nvme devices to get the TUR checker assigned to
> them. This is because there is nothing in detect_alua() to make it
> only
> work on scsi devices, and select_checker wasn't updated to handle
> detect_alua() failing without setting pp->tpgs to TPGS_NONE.
> 
> detect_alua() should automatically set pp->tpgs to TPGS_NONE and exit
> on
> non-scsi devices. Also, select_checker() should not assume that a
> devices is ALUA, simply because if failed to detect if alua was
> supported.
> 
> Fixes: 8794a776 "libmultipath: fix ALUA autodetection when paths are
>                  down"
> Signed-off-by: Benjamin Marzinski <bmarzins@xxxxxxxxxx>

Reviewed-by: Martin Wilck <mwilck@xxxxxxxx>


--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/dm-devel




[Index of Archives]     [DM Crypt]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Packaging]     [Fedora SELinux]     [Yosemite Discussion]     [KDE Users]     [Fedora Docs]

  Powered by Linux