Re: [PATCH] 11-dm-mpath.rules: Fix udev rule processing during coldplug

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Ben, Hi Christophe,

On Tue, 2020-06-02 at 16:21 -0500, Benjamin Marzinski wrote:
> On Tue, Jun 02, 2020 at 05:54:43PM +0200, mwilck@xxxxxxxx wrote:
> > From: Martin Wilck <mwilck@xxxxxxxx>
> > 
> > DM_SUBSYSTEM_UDEV_FLAG0 is used to indicate that upper layer
> > udev rules don't need to be processed for multipath maps, e.g.
> > for map reloads.
> > 
> > However, this can fail if maps were created during initrd
> > processing,
> > but udev processing for the change events of these maps didn't
> > complete because udevd was killed to switch root. So, in the
> > coldplug
> > case, play safe and process the rules once more.
> > 
> > Signed-off-by: Martin Wilck <mwilck@xxxxxxxx>
> Reviewed-by: Benjamin Marzinski <bmarzins@xxxxxxxxxx>

This patch was wrong. It doesn't hurt but it also doesn't help; it
simply has no effect because DM_SUBSYSTEM_UDEV_FLAG0
is never set on "add" uevents.

Christophe, please don't apply it.

Martin


--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/dm-devel




[Index of Archives]     [DM Crypt]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Packaging]     [Fedora SELinux]     [Yosemite Discussion]     [KDE Users]     [Fedora Docs]

  Powered by Linux