On Thu, Jun 18, 2020 at 03:27:22PM +0000, Martin Wilck wrote: > On Wed, 2020-06-17 at 19:24 -0500, Benjamin Marzinski wrote: > > Make do_get_info() differentiate between dm failures and missing > > devices, and update callers to retain their current behavior. Also, > > rename it and make it external. These changes will be used by future > > commits. > > > > Signed-off-by: Benjamin Marzinski <bmarzins@xxxxxxxxxx> > > --- > > libmultipath/devmapper.c | 29 ++++++++++++++++------------- > > libmultipath/devmapper.h | 1 + > > 2 files changed, 17 insertions(+), 13 deletions(-) > > > > diff --git a/libmultipath/devmapper.c b/libmultipath/devmapper.c > > index 27d52398..b44f7545 100644 > > --- a/libmultipath/devmapper.c > > +++ b/libmultipath/devmapper.c > > @@ -496,8 +496,14 @@ int dm_addmap_reload(struct multipath *mpp, char > > *params, int flush) > > return 0; > > } > > > > -static int > > -do_get_info(const char *name, struct dm_info *info) > > +/* > > + * Returns: > > + * -1: Error > > + * 0: device does not exist > > + * 1: device exists > > + */ > > Can we use symbolic values here please? In particular as you have > changed the "success" return value from 0 to 1... > > One day we should come up with a proper return value scheme > for libmultipath, defining specific enums for every function > doesn't scale. But do it here for now nonetheless, please. Sure -Ben > > Apart from that, ok. > > Regards > Martin > > -- > Dr. Martin Wilck <mwilck@xxxxxxxx>, Tel. +49 (0)911 74053 2107 > SUSE Software Solutions Germany GmbH > HRB 36809, AG Nürnberg GF: Felix > Imendörffer > -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
