On Tue, 2020-06-09 at 16:35 -0500, Benjamin Marzinski wrote: > I recently got a request to add the Oracle ASM filer driver devices > to > multipath's builtin devnode blacklist. However, instead of having to > do > always this for each device type individually, I decided to make > multipath blacklist all non scsi, nvme, and dasd devnodes by default. > This is what the multipath udev rules already do. > > Changes from v1: > Everything. Martin suggested an alternative method for doing this, > which > is to treat an exclamation mark at the start of the > blacklist/exceptions > regexes as inverting the matching on the rest of the regex. > > Benjamin Marzinski (3): > libmultipath: remove _blacklist_exceptions functions > libmultipath: fix parser issue with comments in strings > libmultipath: invert regexes that start with exclamation point > > libmultipath/blacklist.c | 103 +++++++++++++++------------------- > libmultipath/blacklist.h | 3 + > libmultipath/parser.c | 4 +- > multipath/multipath.conf.5 | 17 ++++-- > tests/blacklist.c | 110 > +++++++++++++++++++++++++++++++++++++ > tests/parser.c | 42 ++++++++++++++ > tests/test-lib.c | 2 +- > 7 files changed, 215 insertions(+), 66 deletions(-) > Very nice work, thank you! Reviewed-by: Martin Wilck <mwilck@xxxxxxxx> -- Dr. Martin Wilck <mwilck@xxxxxxxx>, Tel. +49 (0)911 74053 2107 SUSE Software Solutions Germany GmbH HRB 36809, AG Nürnberg GF: Felix Imendörffer -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
