On 2020/05/23 0:39, Hannes Reinecke wrote:
> Instead of just reporting the errno this patch adds some more
> verbose debugging message in the reclaim path.
>
> Signed-off-by: Hannes Reinecke <hare@xxxxxxx>
> ---
> drivers/md/dm-zoned-reclaim.c | 13 ++++++++++---
> 1 file changed, 10 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/md/dm-zoned-reclaim.c b/drivers/md/dm-zoned-reclaim.c
> index d1a72b42dea2..fba0d48e38a7 100644
> --- a/drivers/md/dm-zoned-reclaim.c
> +++ b/drivers/md/dm-zoned-reclaim.c
> @@ -367,8 +367,11 @@ static int dmz_do_reclaim(struct dmz_reclaim *zrc)
>
> /* Get a data zone */
> dzone = dmz_get_zone_for_reclaim(zmd, dmz_target_idle(zrc));
> - if (!dzone)
> + if (!dzone) {
> + DMDEBUG("(%s): No zone found to reclaim",
> + dmz_metadata_label(zmd));
> return -EBUSY;
> + }
>
> start = jiffies;
> if (dmz_is_cache(dzone) || dmz_is_rnd(dzone)) {
> @@ -412,6 +415,12 @@ static int dmz_do_reclaim(struct dmz_reclaim *zrc)
> }
> out:
> if (ret) {
> + if (ret == -EINTR)
> + DMDEBUG("(%s): reclaim zone %u interrupted",
> + dmz_metadata_label(zmd), rzone->id);
> + else
> + DMDEBUG("(%s): Failed to reclaim zone %u, err %d",
> + dmz_metadata_label(zmd), rzone->id, ret);
> dmz_unlock_zone_reclaim(dzone);
> return ret;
> }
> @@ -515,8 +524,6 @@ static void dmz_reclaim_work(struct work_struct *work)
>
> ret = dmz_do_reclaim(zrc);
> if (ret && ret != -EINTR) {
> - DMDEBUG("(%s): Reclaim error %d",
> - dmz_metadata_label(zmd), ret);
> if (!dmz_check_dev(zmd))
> return;
> }
>
Reviewed-by: Damien Le Moal <damien.lemoal@xxxxxxx>
--
Damien Le Moal
Western Digital Research
--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/dm-devel
