On Mon, 2020-05-18 at 23:57 -0500, Benjamin Marzinski wrote: > I've been playing around with the SID code more and I've decided to > hold > off on submitting the library until I have it working with the SID > multipath module better. Instead, I've pulled out the common code > thatremember_cmdline_wwid > multipath -u/-c and the library can use, and put it into > libmultipath. > > I've also removed some of the ordering differences between the > existing > code and my new code. Right now, the only difference is that if a > path > is currently multipathed, it will always be claimed as a valid path. > > Patches 0001 & 0002 are the same as in my "RFC PATCH v2" set, and > patch > 0005 is the same as my "libmultipath: simplify failed wwid code" > patch. > > Only patches 0003 and 0004 haven't been posted before. > > Changes from v1: > 0003: Minor fixes suggested by Martin Wilck > 0004: Fixed typo, added tests for filter_property() and switched some > tests to pass the check_multipathd code in various ways, > instead > of skipping it, as suggested by Martin Wilck > This set (v2) doesn't apply cleanly to upstream, neither with or without my late patches. It's been generated against a tree that included "Make multipath add wwids from kernel cmdline mpath.wwids with -A" (https://patchwork.kernel.org/patch/4445691/). From my series, it's missing "libmultipath: move libsg into libmultipath". Apart from that, for the series: Reviewed-by: Martin Wilck <mwilck@xxxxxxxx> Martin -- Dr. Martin Wilck <mwilck@xxxxxxxx>, Tel. +49 (0)911 74053 2107 SUSE Software Solutions Germany GmbH HRB 36809, AG Nürnberg GF: Felix Imendörffer -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
