On 2020/05/13 16:10, Hannes Reinecke wrote: > Switch to use dynamic debug to avoid having recompile the kernel > just to enable debugging messages. > > Signed-off-by: Hannes Reinecke <hare@xxxxxxx> > --- > include/linux/device-mapper.h | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/include/linux/device-mapper.h b/include/linux/device-mapper.h > index e2d506dd805e..3d4365fd3001 100644 > --- a/include/linux/device-mapper.h > +++ b/include/linux/device-mapper.h > @@ -556,13 +556,8 @@ void *dm_vcalloc(unsigned long nmemb, unsigned long elem_size); > #define DMINFO(fmt, ...) pr_info(DM_FMT(fmt), ##__VA_ARGS__) > #define DMINFO_LIMIT(fmt, ...) pr_info_ratelimited(DM_FMT(fmt), ##__VA_ARGS__) > > -#ifdef CONFIG_DM_DEBUG Can we remove this from Kconfig as a config option ? > -#define DMDEBUG(fmt, ...) printk(KERN_DEBUG DM_FMT(fmt), ##__VA_ARGS__) > +#define DMDEBUG(fmt, ...) pr_debug(DM_FMT(fmt), ##__VA_ARGS__) > #define DMDEBUG_LIMIT(fmt, ...) pr_debug_ratelimited(DM_FMT(fmt), ##__VA_ARGS__) > -#else > -#define DMDEBUG(fmt, ...) no_printk(fmt, ##__VA_ARGS__) > -#define DMDEBUG_LIMIT(fmt, ...) no_printk(fmt, ##__VA_ARGS__) > -#endif > > #define DMEMIT(x...) sz += ((sz >= maxlen) ? \ > 0 : scnprintf(result + sz, maxlen - sz, x)) > Otherwise, looks good to me. Reviewed-by: Damien Le Moal <damien.lemoal@xxxxxxx> -- Damien Le Moal Western Digital Research -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
