On 2020/4/25 15:53, Christoph Hellwig wrote:
> The make_request_fn pointer should only be assigned by blk_alloc_queue.
> Fix a left over manual initialization.
>
> Fixes: ff27668ce809 ("bcache: pass the make_request methods to blk_queue_make_request")
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
It looks good to me.
Reviewed-by: Coly Li <colyli@xxxxxxx>
Thanks.
Coly Li
> ---
> drivers/md/bcache/request.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/md/bcache/request.c b/drivers/md/bcache/request.c
> index 71a90fbec314b..77d1a26975174 100644
> --- a/drivers/md/bcache/request.c
> +++ b/drivers/md/bcache/request.c
> @@ -1372,7 +1372,6 @@ void bch_flash_dev_request_init(struct bcache_device *d)
> {
> struct gendisk *g = d->disk;
>
> - g->queue->make_request_fn = flash_dev_make_request;
> g->queue->backing_dev_info->congested_fn = flash_dev_congested;
> d->cache_miss = flash_dev_cache_miss;
> d->ioctl = flash_dev_ioctl;
>
--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/dm-devel
