There is a bug in the way dm-clone handles partial region discards,
which can lead to discarding the wrong blocks or trying to discard
blocks beyond the end of the device.
This could lead to data corruption, if the destination device indeed
discards the underlying blocks, i.e., if the discard operation results
in the original contents of a block to be lost.
The bug manifests when we try to discard part of a single region, i.e.,
when we try to discard a block with size < region_size, and the discard
request both starts at an offset with respect to the beginning of that
region and ends before the end of the region.
The root of the bug is the code that calculates the range of regions
covered by a discard request and decides which regions to discard.
For more information, please see the relevant commit.
As part of fixing this bug, I also audited dm-clone for other
arithmetic/overflow related bugs and found the following:
1. Missing overflow check for the total number of regions
2. Missing casts when converting from regions to sectors
3. Wrong return type of dm_clone_nr_of_hydrated_regions(), which caused
an unwanted sign extension to occur.
Again, more information can be found in the relevant commits.
Nikos Tsironis (4):
dm clone: Fix handling of partial region discards
dm clone: Add overflow check for number of regions
dm clone: Add missing casts to prevent overflows and data corruption
dm clone metadata: Fix return type of
dm_clone_nr_of_hydrated_regions()
drivers/md/dm-clone-metadata.c | 15 +++++++++-
drivers/md/dm-clone-metadata.h | 2 +-
drivers/md/dm-clone-target.c | 66 ++++++++++++++++++++++++++++++------------
3 files changed, 62 insertions(+), 21 deletions(-)
--
2.11.0
--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/dm-devel
