On Tue, 2020-03-24 at 16:03 -0500, Benjamin Marzinski wrote: > There is nothing wrong with is_queueing not being set at the start > of __set_no_path_retry(), it will always get set before it is > accessed, > but gcc 8.2.1 is failing with > > structs_vec.c: In function ‘__set_no_path_retry’: > structs_vec.c:339:7: error: ‘is_queueing’ may be used uninitialized > in > this function [-Werror=maybe-uninitialized] > bool is_queueing; > ^~~~~~~~~~~ > > so, assign a value to make it happy. > > Signed-off-by: Benjamin Marzinski <bmarzins@xxxxxxxxxx> > --- > libmultipath/structs_vec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) That actually looks like a gcc bug to me. Anyway: Reviewed-by: Martin Wilck <mwilck@xxxxxxx> -- Dr. Martin Wilck <mwilck@xxxxxxxx>, Tel. +49 (0)911 74053 2107 SUSE Software Solutions Germany GmbH HRB 36809, AG Nürnberg GF: Felix Imendörffer -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
