Re: [PATCH 4/4] libmpathpersist: ABI change: limit data-in/out size to 8192 bytes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 2020-03-15 at 01:27 +0100, Martin Wilck wrote:
> 
> A program written against the old API might assume that the length of
> private_buffer was MPATH_MAX_PARAM_LEN, and call e.g.
> memset(private_buffer, 0, MPATH_MAX_PARAM_LEN), overwriting
> num_transportid.

And programs compiled against old headers would obviously use the
wrong offsets for num_transportids and trnptid_list.

Similar for struct print_fulldescr_list.descriptors.

So I this does indeed break the ABI. Perhaps we shouldn't apply this
without implementing clean so numbering.

Regards
Martin



--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/dm-devel




[Index of Archives]     [DM Crypt]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Packaging]     [Fedora SELinux]     [Yosemite Discussion]     [KDE Users]     [Fedora Docs]

  Powered by Linux