Re: [PATCH 5/5] libmultipath: cleanup old issues with directio checker

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2020-02-19 at 00:54 -0600, Benjamin Marzinski wrote:
> The directio checker manually aligns its directio buffer, instead of
> using posix_memalign(). It also defaults the block size for the read
> to
> 512, which may be too small for 4k devices, and it only waits for 5
> ns
> for IO completion before giving up and setting the path to pending,
> which means that in will virtually always set the path to pending on
> the
> check when the IO is issued.
> 
> Signed-off-by: Benjamin Marzinski <bmarzins@xxxxxxxxxx>
> 
> ---
>  libmultipath/checkers/directio.c | 13 ++++---------
>  tests/directio.c                 |  1 -
>  2 files changed, 4 insertions(+), 10 deletions(-)

Reviewed-by: Martin Wilck <mwilck@xxxxxxxx>



--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/dm-devel




[Index of Archives]     [DM Crypt]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Packaging]     [Fedora SELinux]     [Yosemite Discussion]     [KDE Users]     [Fedora Docs]

  Powered by Linux