On Wed, 2020-02-19 at 00:54 -0600, Benjamin Marzinski wrote: > The directio checker previously made sure to always keep an aio_group > around after loading or resetting the checker. There is no need to do > this, and removing this code simplifies the checker. With this > change, > there is no longer a need for a load or unload checker function, only > a > reset function which is run when the checker is reset or unloaded. > Changing this broke a number of tests, so the unit tests have been > updated as well. > > Signed-off-by: Benjamin Marzinski <bmarzins@xxxxxxxxxx> > --- > libmultipath/checkers.c | 26 ++--- > libmultipath/checkers.h | 2 +- > libmultipath/checkers/directio.c | 43 +------- > tests/directio.c | 177 +++++++++++++-------------- > ---- > 4 files changed, 81 insertions(+), 167 deletions(-) Many thanks for making this change. I feared that the directio tests were tied quite closely to implementation details... Reviewed-by: Martin Wilck <mwilck@xxxxxxxx> -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
