> +static int pmem_dax_zero_page_range(struct dax_device *dax_dev, u64 offset, > + size_t len) > +{ > + struct pmem_device *pmem = dax_get_private(dax_dev); > + blk_status_t rc; > + > + rc = pmem_do_write(pmem, ZERO_PAGE(0), 0, offset, len); > + return blk_status_to_errno(rc); No real need for the rc variable here. Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx> -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel