Dne 07. 11. 19 v 20:50 Mikulas Patocka napsal(a):
On Thu, 7 Nov 2019, Maged Mokhtar wrote:
On 07/11/2019 21:09, Mike Snitzer wrote:
On Thu, Nov 07 2019 at 1:55pm -0500,
Maged Mokhtar <mmokhtar@xxxxxxxxxxx> wrote:
On 06/11/2019 17:08, Mike Snitzer wrote:
On Tue, Nov 05 2019 at 4:19pm -0500,
Maged Mokhtar <mmokhtar@xxxxxxxxxxx> wrote:
Gentle ping please.
It could add flexibility in changing cache parameters after device
creation.
I'm inclined to _not_ take this type of change.
Why isn't changing the config parameters via table reload viable for
you?
IMHO any target update that is changing behavior of target should be made via
table reload - typical symptom of such requirement is - that change may
requires some memory allocation, metadata updates, synchronization of data on
used disks...
If these things are made via messages - there is 'no simply way' back
(while with table reload - we drop table if 'suspend' cannot proceed).
Another problem is - that if change is not visible via 'table line',
future table access might be unaware of the change and may reload
table and expect different behavior.
Also actual table update via suspend & resume cannot be much slower then
message anyway - you can use 'noflush' if you need to - depending on the
situation it might be usable - and such operation is very quick.
Regards
Zdenek
--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/dm-devel
