Hi,
The patch looks good to me, as for gpart, I needed it so I've taken the bits and pieces that floated around and merged them all into one place from all distributions that I could find. As for users, in Debian the number of users is around 250 so it's a very low usage program but I guess that would always be unless very many people lost their partitions every day :-)
Cheers,
Baruch
P.S. While I'm sort of maintaining the program, it's only maintenance, no active development is going on with it and very rarely do I get a patch or an issue reported.
On Tue, Oct 8, 2019 at 11:18 AM Petr Vorel <petr.vorel@xxxxxxxxx> wrote:
Hi Christoph,
> On Wed, Oct 02, 2019 at 08:05:09AM +0200, Petr Vorel wrote:
> > I tried to search in [1], with not much success, I don't know the original name
> > of the struct and struct members are quite similar. Do you have a tip, where it
> > could be or would you dare to search?
> No, I don't know Solaris very well.
> > Christophe already merged my patch as
> > 129e6fe6 ("kpartx: Use __kernel_daddr_t for solaris_x86_slice.s_start")
> > But, according to your comments it looks to me better to use the exact structure
> > kernel uses. So, if we don't find anything, I'd be for using kernel struct.
> Thanks, that would be great.
I've sent a patch, as RFC, Cc also Baruch Even, the gpart maintainer.
I wonder, if there is anybody actually using this code nowadays.
Kind regards,
Petr
-- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
