From: Martin Wilck <mwilck@xxxxxxxx>
clang enables -Wformat-nonliteral with our compiler flags, and
thus needs these format(printf, ...) attributes.
Signed-off-by: Martin Wilck <mwilck@xxxxxxxx>
---
libdmmp/libdmmp_private.h | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/libdmmp/libdmmp_private.h b/libdmmp/libdmmp_private.h
index 3e813cb4..ac85b63f 100644
--- a/libdmmp/libdmmp_private.h
+++ b/libdmmp/libdmmp_private.h
@@ -131,13 +131,15 @@ DMMP_DLL_LOCAL void _dmmp_path_free(struct dmmp_path *dmmp_p);
DMMP_DLL_LOCAL void _dmmp_log(struct dmmp_context *ctx, int priority,
const char *file, int line,
const char *func_name,
- const char *format, ...);
+ const char *format, ...)
+ __attribute__((format(printf, 6, 7)));
DMMP_DLL_LOCAL void _dmmp_log_err_str(struct dmmp_context *ctx, int rc);
DMMP_DLL_LOCAL void _dmmp_log_stderr(struct dmmp_context *ctx, int priority,
const char *file, int line,
const char *func_name, const char *format,
- va_list args);
+ va_list args)
+ __attribute__((format(printf, 6, 0)));
#define _dmmp_log_cond(ctx, prio, arg...) \
@@ -164,7 +166,7 @@ DMMP_DLL_LOCAL void _dmmp_log_stderr(struct dmmp_context *ctx, int priority,
do { \
if (ptr == NULL) { \
rc = DMMP_ERR_NO_MEMORY; \
- _error(ctx, dmmp_strerror(rc)); \
+ _error(ctx, "%s", dmmp_strerror(rc)); \
goto goto_out; \
} \
} while(0)
--
2.23.0
--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/dm-devel
