On Wed, Sep 11 2019 at 2:46pm -0400, Nikos Tsironis <ntsironis@xxxxxxxxxxx> wrote: > On 9/11/19 9:22 PM, Mike Snitzer wrote:> > > I resolved this and pushed new code, thanks! > > > > Hi Mike, > > I just saw the report and was about to fix it, but I noticed you have > already fixed it. Thanks a lot. > > I had forgotten to include the header file for vmalloc(), but I saw you > used kvmalloc(), which is even better. > > I took a quick look at the diff and there are a few places that still > need fixing: > > drivers/md/dm-clone-target.c:563: clone->ht = vmalloc(sz *sizeof(struct hash_table_bucket)); > drivers/md/dm-clone-target.c:579: vfree(clone->ht); > > Also, the allocation of cmd->region_map is done with kvmalloc(), but the > deallocation is still done with vfree(): > > drivers/md/dm-clone-metadata.c:597: vfree(cmd->region_map); > > I will be away from keyboard for the rest of the day, but I will take a > closer look at the diff tomorrow and I will send a new version fixing > these and any other issues I might find. I fixed the above up, thanks. Please just send any incremental patches relative to what I have staged now. Mike -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
