On 23/08/19 18:51, Song Liu wrote: > I guess md_is_broken() should return bool? Otherwise, looks good to me. Just an outsider's observation - if the function is actually checking whether a member is missing maybe it should read broken = md_member_is_missing(); That way the function says what it does, and the assignment says what you're doing with it. Cheers, Wol -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
