On Tue, Aug 27 2019 at 10:09am -0400, Nikos Tsironis <ntsironis@xxxxxxxxxxx> wrote: > Hello, > > This is a kind reminder for this patch set. I'm bumping this thread to > solicit your feedback. > > Following the discussion with Heinz, I have provided extensive > benchmarks that show dm-clone's significant performance increase > compared to a dm-snapshot/dm-raid1 stack. > > How can we move forward with the review of dm-clone, so it can > eventually be merged upstream? > > Looking forward to your feedback, I actually pulled it into my local dm-5.4 branch yesterday and have started reviewing. Firrst pass it looks like you've got solid code; a lot of familiar code patterns too (barrowed from thinp, etc). But the first thing that is tripping me up is the name "dm-clone" considering how cloning is so fundamental to all DM. The second term that is just awkward is "hydration". But that is just my initial thought. I'll need the rest of the week to really dig in and have more constructive feedback for you. Thanks for the ping; wasn't needed in this instance but it never hurts. Mike -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
