Re: [PATCH] multipath: add print_foreign option

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2019-08-14 at 12:22 -0500, Benjamin Marzinski wrote:
> This adds a print_foreign multipath.conf defaults option, that allows
> users to disable printing foreign devices and paths. It defaults to
> "yes".
> 
> Signed-off-by: Benjamin Marzinski <bmarzins@xxxxxxxxxx>
> ---
>  libmultipath/config.c      |  1 +
>  libmultipath/config.h      |  1 +
>  libmultipath/defaults.h    |  1 +
>  libmultipath/dict.c        |  4 ++++
>  multipath/main.c           |  4 ++--
>  multipath/multipath.conf.5 | 12 ++++++++++++
>  multipathd/cli_handlers.c  | 40 ++++++++++++++++++++++++++++++----
> ----
>  7 files changed, 53 insertions(+), 10 deletions(-)
> 

The general idea is good, and has been requested from SUSE, too.

But, as "foreign" is designed to be generic and different foreign
libraries might be possible in the future, I'd like to this a bit
differently:

    enable_foreign = "$REGEXP"

Where REGEXP would be used to match the foreign library names.
The default value of REGEXP would be ".*" or "nvme". Users who want
to disable printing foreign maps would set it e.g. to "^$", or "NONE".

I'll send a patch soon.

Regards,
Martin



--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/dm-devel



[Index of Archives]     [DM Crypt]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Packaging]     [Fedora SELinux]     [Yosemite Discussion]     [KDE Users]     [Fedora Docs]

  Powered by Linux