On 31/07/2019 16:43, Song Liu wrote: >[...] >> @@ -4315,6 +4329,7 @@ array_state_store(struct mddev *mddev, const char *buf, size_t len) >> break; >> case write_pending: >> case active_idle: >> + case broken: >> /* these cannot be set */ >> break; >> } > > Maybe it is useful to set "broken" state? When user space found some issues > with the drive? > > Thanks, > Song Hi Song, thanks a lot for your feedback. I can easily add that in V2 along with Neil's suggestion, I agree with you. There is a 2/2 patch regarding the mdadm counterpart; you should have received the email, but for completeness, the link is: lore.kernel.org/linux-block/20190729203135.12934-3-gpiccoli@xxxxxxxxxxxxx Thanks, Guilherme -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
