On 29/07/2019 21:08, NeilBrown wrote: >[...] >> + if (unlikely(test_bit(MD_BROKEN, &mddev->flags))) { >> + bio_io_error(bio); >> + return BLK_QC_T_NONE; >> + } > > I think this should only fail WRITE requests, not READ requests. > > Otherwise the patch is probably reasonable. > > NeilBrown Thanks for the feedback Neil! I thought about it; it seemed to me better to deny/fail the reads instead of returning "wrong" reads, since a file read in a raid0 will be incomplete if one member is missing. But it's fine for me to change that in the next iteration of this patch. Cheers, Guilherme -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel