Hi, Just a couple of minor nits: On 7/17/19 5:46 PM, Jaskaran Khurana wrote: > diff --git a/drivers/md/Kconfig b/drivers/md/Kconfig > index 3834332f4963..c2b04d226c90 100644 > --- a/drivers/md/Kconfig > +++ b/drivers/md/Kconfig > @@ -490,6 +490,18 @@ config DM_VERITY > > If unsure, say N. > > +config DM_VERITY_VERIFY_ROOTHASH_SIG > + def_bool n It already defaults to n, so we usually try to omit that (don't repeat it). > + bool "Verity data device root hash signature verification support" > + depends on DM_VERITY > + select SYSTEM_DATA_VERIFICATION > + help "help" should only be indented by one tab (and not the extra 2 spaces). > + The device mapper target created by DM-VERITY can be validated if the > + pre-generated tree of cryptographic checksums passed has a pkcs#7 > + signature file that can validate the roothash of the tree. > + > + If unsure, say N. > + > config DM_VERITY_FEC > bool "Verity forward error correction support" > depends on DM_VERITY thanks. -- ~Randy -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
