On Wed, Jun 05, 2019 at 09:27:08PM +0800, zhangyi (F) wrote: > Currently, although we submit super bios in log-write thread orderly > (the super.nr_entries is incremented by each logged entry), the > submit_bio() cannot make sure that each super sector is written to log > device in order. So the submitting bio of each super sector may be > out-of-order, and then the final nr_entries maybe small than the real > entries submitted. > > This problem can be reproduced by the xfstests generic/455 with ext4, > which may complained below after running the test: > > QA output created by 455 > -Silence is golden > +mark 'end' does not exist > > This patch serialize submitting super secotrs to make sure each super > sectors are written to log disk in order, so that we can prevent the > latest nr_entries be rewritten by some old super bios. > > Signed-off-by: zhangyi (F) <yi.zhang@xxxxxxxxxx> > Suggested-by: Josef Bacik <josef@xxxxxxxxxxxxxx> > --- > Changes since v1: > - Switch to use completion instead of wait_queue to synchronize > submitting super bios. > Reviewed-by: Josef Bacik <josef@xxxxxxxxxxxxxx> Thanks, Josef -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
