Re: [patch V2 01/29] tracing: Cleanup stack trace code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [patch V2 01/29] tracing: Cleanup stack trace code
From: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
Date: Thu, 18 Apr 2019 23:14:45 +0200 (CEST)
Cc: Mike Snitzer <snitzer@xxxxxxxxxx>, David Airlie <airlied@xxxxxxxx>, Catalin Marinas <catalin.marinas@xxxxxxx>, Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx>, dri-devel@xxxxxxxxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, dm-devel@xxxxxxxxxx, Alexander Potapenko <glider@xxxxxxxxxx>, Christoph Lameter <cl@xxxxxxxxx>, Christoph Hellwig <hch@xxxxxx>, Alasdair Kergon <agk@xxxxxxxxxx>, Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>, linux-arch@xxxxxxxxxxxxxxx, x86@xxxxxxxxxx, kasan-dev@xxxxxxxxxxxxxxxx, Johannes Thumshirn <jthumshirn@xxxxxxx>, Andrey Ryabinin <aryabinin@xxxxxxxxxxxxx>, Alexey Dobriyan <adobriyan@xxxxxxxxx>, intel-gfx@xxxxxxxxxxxxxxxxxxxxx, David Rientjes <rientjes@xxxxxxxxxx>, Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx>, Akinobu Mita <akinobu.mita@xxxxxxxxx>, Steven Rostedt <rostedt@xxxxxxxxxxx>, Josef Bacik <josef@xxxxxxxxxxxxxx>, Mike Rapoport <rppt@xxxxxxxxxxxxxxxxxx>, Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx>, Andy Lutomirski <luto@xxxxxxxxxx>, Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx>, David Sterba <dsterba@xxxxxxxx>, Dmitry Vyukov <dvyukov@xxxxxxxxxx>, Chris Mason <clm@xxxxxx>, LKML <linux-kernel@xxxxxxxxxxxxxxx>, Pekka Enberg <penberg@xxxxxxxxxx>, iommu@xxxxxxxxxxxxxxxxxxxxxxxxxx, Daniel Vetter <daniel@xxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Robin Murphy <robin.murphy@xxxxxxx>, linux-btrfs@xxxxxxxxxxxxxxx
In-reply-to: <20190418135721.5vwd6ngxagrrrrtt@treble>
References: <20190418084119.056416939@linutronix.de> <20190418084253.142712304@linutronix.de> <20190418135721.5vwd6ngxagrrrrtt@treble>
User-agent: Alpine 2.21 (DEB 202 2017-01-01)

On Thu, 18 Apr 2019, Josh Poimboeuf wrote:

> On Thu, Apr 18, 2019 at 10:41:20AM +0200, Thomas Gleixner wrote:
> > - Remove the extra array member of stack_dump_trace[]. It's not required as
> >   the stack tracer stores at max array size - 1 entries so there is still
> >   an empty slot.
> 
> What is the empty slot used for?

I was trying to find an answer but failed. Maybe it's just historical
leftovers or Steven knows where the magic is in this maze.

Thanks,

	tglx

--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/dm-devel

Follow-Ups:
- Re: [patch V2 01/29] tracing: Cleanup stack trace code
  - From: Steven Rostedt

References:
- [patch V2 00/29] stacktrace: Consolidate stack trace usage
  - From: Thomas Gleixner
- [patch V2 01/29] tracing: Cleanup stack trace code
  - From: Thomas Gleixner
- Re: [patch V2 01/29] tracing: Cleanup stack trace code
  - From: Josh Poimboeuf

Prev by Date: [patch V2 00/29] stacktrace: Consolidate stack trace usage
Next by Date: [patch V2 05/29] proc: Simplify task stack retrieval
Previous by thread: Re: [patch V2 01/29] tracing: Cleanup stack trace code
Next by thread: Re: [patch V2 01/29] tracing: Cleanup stack trace code
Index(es):
- Date
- Thread

[Index of Archives] [DM Crypt] [Fedora Desktop] [ATA RAID] [Fedora Marketing] [Fedora Packaging] [Fedora SELinux] [Yosemite Discussion] [KDE Users] [Fedora Docs]