On Sat, 2019-03-30 at 01:05 -0500, Benjamin Marzinski wrote: > If disable_changed_wwids is set, when multipathd gets a change event > on > a path, it verifies that the wwid hasn't changed in > uev_update_path(). > If get_uid() failed, uev_update_path treated this as a wwid change to > 0. > This could cause paths to suddenly be dropped due to an issue with > getting the wwid. Even if get_uid() failed because the path was > down, > it no change uevent happend when it later became active, multipathd > would continue to ignore the path. Also, scsi_uid_fallback() clears > the > failure return if it doesn't attempt to fallback, causing get_uid() > to return success, when it actually failed. > > Multipathd should neither set nor clear wwid_changed if get_uid() > returned failure. Also, scsi_uid_fallback() should retain the old > return > value if it doesn't attempt to fallback. > > Signed-off-by: Benjamin Marzinski <bmarzins@xxxxxxxxxx> Reviewed-by: Martin Wilck <mwilck@xxxxxxxx> -- Dr. Martin Wilck <mwilck@xxxxxxxx>, Tel. +49 (0)911 74053 2107 SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
