On 3/7/19 8:20 PM, Martin Wilck wrote: > On Thu, 2019-03-07 at 19:22 +0100, Xose Vazquez Perez wrote: >> On 3/7/19 3:54 PM, Martin Wilck wrote: >>> From: Dominique Leuenberger <dimstar@xxxxxxxxxxxx> >>> >>> Since systemd 241, systemctl --version no longer 'just' prints out >>> the >>> version, but gives more information like git commit ref and >>> whatnot. In >>> it's shortest form, it gives something like "systemd 241 (241)", >>> which when >>> passed as parameter "-DUSE_SYSTEMD=241 (241)" results in shell >>> errors. >>> >>> Try to retrieve the version from pkg-config instead, and if that >>> fails, >>> discard anything after the first number in "systemctl --version" >>> output. >> >> There is a simpler patch in Fedora, see below. > > Which is equivalent to the "else" clause of my patch, thanks for > pointing it out. > > But pkg-config should be the way to go in the future, so why not > use it if we can? I agree. -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
