On Tue, Feb 05 2019 at 12:06pm -0500,
Milan Broz <gmazyland@xxxxxxxxx> wrote:
> Hi Mike,
>
> since 5.0-rc4 we are not able to use LUKS2 devices with 4k sector size.
>
> For example,
> # cryptsetup luksFormat --type luks2 -c aes-xts-plain64 --integrity hmac-sha256 /dev/sdc --sector-size 4096
>
> fails with these syslog errors:
> device-mapper: crypt: Integrity AEAD, tag size 32, IV size 0.
> device-mapper: integrity: Invalid integrity data size 32768, expected 4096
> device-mapper: integrity: Invalid integrity data size 32768, expected 4096
>
> (with 512-byte sectors it seems to work ok)
>
> Bisect shows this commit in rc4 is the problematic one (reverting fixes the problem):
>
> commit 57c36519e4b949f89381053f7283f5d605595b42
> Author: Mike Snitzer <snitzer@xxxxxxxxxx>
> Date: Wed Jan 16 18:53:26 2019 -0500
>
> dm: fix clone_bio() to trigger blk_recount_segments()
>
> DM's clone_bio() now benefits from using bio_trim() by fixing the fact
> that clone_bio() wasn't clearing BIO_SEG_VALID like bio_trim() does;
> which triggers blk_recount_segments() via bio_phys_segments().
>
> Reviewed-by: Ming Lei <ming.lei@xxxxxxxxxx>
> Signed-off-by: Mike Snitzer <snitzer@xxxxxxxxxx>
>
> Could you please check what is missing in the patch?
Could be that this bio_trim() check is causing it to return early?:
if (offset == 0 && size == bio->bi_iter.bi_size)
return;
But I'll just effectively revert 57c36519e4b94. I don't have time right
now to dwell on _why_ this patch, which seemed to be obvious cleanup,
isn't safe.
Thanks!
Mike
--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/dm-devel
