Hi
Please submit patch this to Linus before 5.0 is released.
Mikulas
waitqueue_active without preceding barrier is unsafe, see the comment
before waitqueue_active definition in include/linux/wait.h.
This patch changes it to wq_has_sleeper.
Signed-off-by: Mikulas Patocka <mpatocka@xxxxxxxxxx>
Fixes: 6f75723190d8 ("dm: remove the pending IO accounting")
---
drivers/md/dm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-2.6/drivers/md/dm.c
===================================================================
--- linux-2.6.orig/drivers/md/dm.c 2019-02-04 20:18:03.000000000 +0100
+++ linux-2.6/drivers/md/dm.c 2019-02-04 20:18:03.000000000 +0100
@@ -699,7 +699,7 @@ static void end_io_acct(struct dm_io *io
true, duration, &io->stats_aux);
/* nudge anyone waiting on suspend queue */
- if (unlikely(waitqueue_active(&md->wait)))
+ if (unlikely(wq_has_sleeper(&md->wait)))
wake_up(&md->wait);
}
--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/dm-devel
