On Wed, 2019-01-30 at 16:13 -0600, Benjamin Marzinski wrote: > I've been playing around with the marginal path code, and I've run > into > a couple of things that could be cleaned up. The one important issue > is > that the marginal paths code tries to enqueue the path for IO error > checking when it is down. To enqueue the path, it needs to open the > device, which can fail because the path is down. Instead, it should > wait for the path to come back up before it queues it, and starts the > IO > error checking. This is fixed in patch 0003. The other patches are > mostly cleanups. The issues they fix aren't actually breaking > things. > > Benjamin Marzinski (4): > libmultipath: handle existing paths in marginal_path enqueue > multipathd: cleanup marginal paths checking timers > libmultipath: fix marginal paths queueing errors > libmultipath: fix marginal_paths nr_active check > > libmultipath/io_err_stat.c | 71 +++++++++++++++--------------------- > -- > libmultipath/io_err_stat.h | 2 +- > multipathd/main.c | 3 +- > 3 files changed, 31 insertions(+), 45 deletions(-) > For the set: Reviewed-by: Martin Wilck <mwilck@xxxxxxxx -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
