On Thu, 2018-12-13 at 10:10 -0600, Kyle Mahlkuch wrote: > Certain IBM FlashSystem LUNs can return up to 85 bytes of serial > number in the Unit Serial Number VPD page, which is larger than > the current SERIAL_SIZE definition of 65 bytes. Since the max > size of this field does not appear to be defined in SPC, increasing > to 128 bytes should hopefully prevent us from hitting this > in future. > > This is an example of a serial number from a FlashSystem: > Unit serial number VPD page: > Unit serial number: > 3321360050764008101AB300000000000012204214503IBMfcp Your example still doesn't fly, this serial number fits nicely in 65 bytes :-) Anyway, you've shown other examples off-list where the serial number was actually longer. So: > Before this patch multipath returns the error: > Jul 17 11:24:58 | vpd pg80 overflow, 85/65 bytes required > > After the patch is applied the error no longer occur. > > Signed-off-by: Kyle Mahlkuch <kmahlkuc@xxxxxxxxxxxxxxxxxx> Reviewed-by: Martin Wilck <mwilck@xxxxxxxx> Please resend, and add Christophe to the recepients. > --- > libmultipath/structs.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libmultipath/structs.h b/libmultipath/structs.h > index bfa660a..00a1b1a 100644 > --- a/libmultipath/structs.h > +++ b/libmultipath/structs.h > @@ -8,7 +8,7 @@ > #include "byteorder.h" > > #define WWID_SIZE 128 > -#define SERIAL_SIZE 65 > +#define SERIAL_SIZE 128 > #define NODE_NAME_SIZE 224 > #define PATH_STR_SIZE 16 > #define PARAMS_SIZE 4096 > -- > 1.8.3.1 > > -- > dm-devel mailing list > dm-devel@xxxxxxxxxx > https://www.redhat.com/mailman/listinfo/dm-devel -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
