Since 1e79548, we don't fallback from /sys/dev/block to /proc/partitions anyway. The strncmp() at "skip_proc" is doomed to fail. So we might as well return immediately. Also, decrease the log level; whether this failure is noteworthy is rather up to the callers to decide. Signed-off-by: Martin Wilck <mwilck@xxxxxxxx> --- libmultipath/util.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libmultipath/util.c b/libmultipath/util.c index b5d2e706..28eb7577 100644 --- a/libmultipath/util.c +++ b/libmultipath/util.c @@ -191,7 +191,8 @@ int devt2devname(char *devname, int devname_len, char *devt) return 0; } } - goto skip_proc; + condlog(4, "%s is invalid", block_path); + return 1; } memset(block_path, 0, sizeof(block_path)); @@ -220,7 +221,7 @@ int devt2devname(char *devname, int devname_len, char *devt) } } fclose(fd); -skip_proc: + if (strncmp(block_path,"/sys/block", 10)) { condlog(3, "No device found for %u:%u", major, minor); return 1; -- 2.19.1 -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel