Re: [PATCH V10 04/19] block: use bio_for_each_bvec() to map sg

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH V10 04/19] block: use bio_for_each_bvec() to map sg
From: Ming Lei <ming.lei@xxxxxxxxxx>
Date: Mon, 19 Nov 2018 15:51:55 +0800
Cc: Mike Snitzer <snitzer@xxxxxxxxxx>, linux-mm@xxxxxxxxx, dm-devel@xxxxxxxxxx, "Darrick J . Wong" <darrick.wong@xxxxxxxxxx>, cluster-devel@xxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, Shaohua Li <shli@xxxxxxxxxx>, Kent Overstreet <kent.overstreet@xxxxxxxxx>, Boaz Harrosh <ooo@xxxxxxxxxxxxxxx>, Gao Xiang <gaoxiang25@xxxxxxxxxx>, Coly Li <colyli@xxxxxxx>, linux-raid@xxxxxxxxxxxxxxx, Bob Peterson <rpeterso@xxxxxxxxxx>, linux-bcache@xxxxxxxxxxxxxxx, Alexander Viro <viro@xxxxxxxxxxxxxxxxxx>, Dave Chinner <dchinner@xxxxxxxxxx>, David Sterba <dsterba@xxxxxxxx>, Jens Axboe <axboe@xxxxxxxxx>, linux-block@xxxxxxxxxxxxxxx, "Theodore Ts'o" <tytso@xxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, linux-xfs@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-erofs@xxxxxxxxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx
In-reply-to: <20181116133314.GC3165@lst.de>
References: <20181115085306.9910-1-ming.lei@redhat.com> <20181115085306.9910-5-ming.lei@redhat.com> <20181116133314.GC3165@lst.de>
User-agent: Mutt/1.9.1 (2017-09-22)

On Fri, Nov 16, 2018 at 02:33:14PM +0100, Christoph Hellwig wrote:
> > +	if (!*sg)
> > +		return sglist;
> > +	else {
> 
> No need for an else after an early return.

OK, good catch!

Thanks,
Ming

--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/dm-devel

References:
- [PATCH V10 00/19] block: support multi-page bvec
  - From: Ming Lei
- [PATCH V10 04/19] block: use bio_for_each_bvec() to map sg
  - From: Ming Lei
- Re: [PATCH V10 04/19] block: use bio_for_each_bvec() to map sg
  - From: Christoph Hellwig

Prev by Date: Re: [PATCH V10 01/19] block: introduce multi-page page bvec helpers
Next by Date: Re: [PATCH V10 03/19] block: use bio_for_each_bvec() to compute multi-page bvec count
Previous by thread: Re: [PATCH V10 04/19] block: use bio_for_each_bvec() to map sg
Next by thread: [PATCH V10 06/19] fs/buffer.c: use bvec iterator to truncate the bio
Index(es):
- Date
- Thread

[Index of Archives] [DM Crypt] [Fedora Desktop] [ATA RAID] [Fedora Marketing] [Fedora Packaging] [Fedora SELinux] [Yosemite Discussion] [KDE Users] [Fedora Docs]