Re: [PATCH V10 11/19] bcache: avoid to use bio_for_each_segment_all() in bch_bio_alloc_pages()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH V10 11/19] bcache: avoid to use bio_for_each_segment_all() in bch_bio_alloc_pages()
From: Christoph Hellwig <hch@xxxxxx>
Date: Fri, 16 Nov 2018 14:46:45 +0100
Cc: Mike Snitzer <snitzer@xxxxxxxxxx>, linux-mm@xxxxxxxxx, dm-devel@xxxxxxxxxx, Christoph Hellwig <hch@xxxxxx>, "Darrick J . Wong" <darrick.wong@xxxxxxxxxx>, cluster-devel@xxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, Shaohua Li <shli@xxxxxxxxxx>, Kent Overstreet <kent.overstreet@xxxxxxxxx>, Boaz Harrosh <ooo@xxxxxxxxxxxxxxx>, Gao Xiang <gaoxiang25@xxxxxxxxxx>, Coly Li <colyli@xxxxxxx>, linux-raid@xxxxxxxxxxxxxxx, Bob Peterson <rpeterso@xxxxxxxxxx>, linux-bcache@xxxxxxxxxxxxxxx, Alexander Viro <viro@xxxxxxxxxxxxxxxxxx>, Dave Chinner <dchinner@xxxxxxxxxx>, David Sterba <dsterba@xxxxxxxx>, Jens Axboe <axboe@xxxxxxxxx>, linux-block@xxxxxxxxxxxxxxx, "Theodore Ts'o" <tytso@xxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, linux-xfs@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-erofs@xxxxxxxxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx
In-reply-to: <20181115085306.9910-12-ming.lei@redhat.com>
References: <20181115085306.9910-1-ming.lei@redhat.com> <20181115085306.9910-12-ming.lei@redhat.com>
User-agent: Mutt/1.5.17 (2007-11-01)

> -	bio_for_each_segment_all(bv, bio, i) {
> +	for (i = 0, bv = bio->bi_io_vec; i < bio->bi_vcnt; bv++) {

This really needs a comment.  Otherwise it looks fine to me.

--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/dm-devel

Follow-Ups:
- Re: [PATCH V10 11/19] bcache: avoid to use bio_for_each_segment_all() in bch_bio_alloc_pages()
  - From: Ming Lei

References:
- [PATCH V10 00/19] block: support multi-page bvec
  - From: Ming Lei
- [PATCH V10 11/19] bcache: avoid to use bio_for_each_segment_all() in bch_bio_alloc_pages()
  - From: Ming Lei

Prev by Date: Re: [PATCH V10 08/19] btrfs: move bio_pages_all() to btrfs
Next by Date: Re: [PATCH V10 13/19] iomap & xfs: only account for new added page
Previous by thread: Re: [PATCH V10 11/19] bcache: avoid to use bio_for_each_segment_all() in bch_bio_alloc_pages()
Next by thread: Re: [PATCH V10 11/19] bcache: avoid to use bio_for_each_segment_all() in bch_bio_alloc_pages()
Index(es):
- Date
- Thread

[Index of Archives] [DM Crypt] [Fedora Desktop] [ATA RAID] [Fedora Marketing] [Fedora Packaging] [Fedora SELinux] [Yosemite Discussion] [KDE Users] [Fedora Docs]