Re: dm writecache: remove unused variable sz in writecache_status

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 24 2018 at 10:38pm -0400,
Shenghui Wang <shhuiw@xxxxxxxxxxx> wrote:

> sz defined but not used in writecache_status. Remove it.
> 
> Signed-off-by: Shenghui Wang <shhuiw@xxxxxxxxxxx>
> ---
>  drivers/md/dm-writecache.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/md/dm-writecache.c b/drivers/md/dm-writecache.c
> index 5f1f80d424dd..562c32f644b8 100644
> --- a/drivers/md/dm-writecache.c
> +++ b/drivers/md/dm-writecache.c
> @@ -2226,7 +2226,6 @@ static void writecache_status(struct dm_target *ti, status_type_t type,
>  {
>  	struct dm_writecache *wc = ti->private;
>  	unsigned extra_args;
> -	unsigned sz = 0;
>  	uint64_t x;
>  
>  	switch (type) {

Have you even compile tested this patch?

DMEMIT implicitly uses sz.  Not saying I like this, but it is what it
is.

Nacked-by: Mike Snitzer <snitzer@xxxxxxxxxx>

--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/dm-devel



[Index of Archives]     [DM Crypt]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Packaging]     [Fedora SELinux]     [Yosemite Discussion]     [KDE Users]     [Fedora Docs]

  Powered by Linux